> On Jan. 11, 2017, 1:21 p.m., Lei Xu wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 482 > > <https://reviews.apache.org/r/55246/diff/2/?file=1600438#file1600438line482> > > > > Is there any concurrent updates? > > > > Say two updates come at the same time, > > `getLastProcessedPermChangeIdCore(pm)` would return the same `last change > > id`? So that two different updates will be persisted with the same change > > Id? > > > > If we just want to increase change id monotonically, we can just > > increase it within the persistent transaction. > > Hao Hao wrote: > There could be concurrent updates. The changeID is a primary key. DB does > not allow duplicate entry for that. So the transcation will fail and retry. > And note that everything within TransactionBlock is in one transaction. > > Lei Xu wrote: > I would suggest to push this auto increment logic into database itself, > with 2 benefits: > > 1) It is more I/O efficient, because it does not need one extra DB read > to fetch existed/last change ID. > 2) No concurrent conflict from your code is needed.
Make sense. Will change it. Thanks! > On Jan. 11, 2017, 1:21 p.m., Lei Xu wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 444 > > <https://reviews.apache.org/r/55246/diff/2/?file=1600438#file1600438line444> > > > > If we keep the old signature of the function, and add the new version > > as an override: > > > > ``` > > public void alterSentryRoleGrantPrivilege(String grantorPrincipal, > > String roleName, TSentryPrivilege privilege) throws Exception { > > alterSentryRoleGrantPrivileg(grantorPrinciple, roleName, > > privilege, null); > > } > > ``` > > > > It might be able to reduce the patch size. > > Hao Hao wrote: > May I ask is there a limitaion of size of a patch? > > Lei Xu wrote: > Sorry for the confused commments. > > I'd consider if the majority of the callers pass `null` as a parameter, > it indicates that the old signature is still valuable. In the meantime, > passing `null` around is very risky, we can limit passing `null` logic > within this old signature, making it easier to test / verify / refactor later. I see, will change it. - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55246/#review161215 ----------------------------------------------------------- On Jan. 13, 2017, 3:06 a.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55246/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 3:06 a.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > SENTRY-1536: Refactor SentryStore transaction management to allow for extra > transactions for a single permission update > > Change-Id: I0571ca25bd8cc20b137baa5b840542f9ef8e7347 > > To persist single permission change, it needs to combine multiple things in a > single transaction: > 1. Doing the actual operation (priv change) > 2. Updating notification ID. > > All the above steps are put into in a single transaction to guarantee that > notificationID handling is atomic. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java > 9ecd9e4d9a862804eab26594c28aa691b89947aa > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PermissionsUpdate.java > a346587fd5c41c826545738faa2f9b95e1d9f0dc > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java > 24729282bf17960152f87b1d3124caeafb47e6b2 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java > 47c9f9dd7105ba5440a81ace9292d730df26f3cd > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java > 2ff715f66ea6c2589a281b988438526546af3d3b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > ece68317c4c0d6a528986fb4f153814f81855214 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 5226b86b0a634d7158c4ff5bfd636a007396d1b5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 51217408386730d9aa01be03d1c74c71369a6b6e > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > f3cefd6a232bfb91db28f04bebcc98ab3c1ca658 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > a35c8d7dde485cf46d61968a211d1dbb6d9d6076 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java > 1c3a4f29984379f5246da8d85fe661320c8a1043 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java > d601b1e107ab3c3a4d9cc5e3038a11547182c5c9 > > Diff: https://reviews.apache.org/r/55246/diff/ > > > Testing > ------- > > New unit tests added in TestHMSFollower. > > > Thanks, > > Hao Hao > >
