> On Feb. 22, 2017, 1:13 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql, > > line 255 > > <https://reviews.apache.org/r/56709/diff/1/?file=1634523#file1634523line255> > > > > Can you put add the contraint into another queries as you did for > > 008-SENTRY-1569.mysql.sql?
I have not added constraint in 008-SENTRY-1569.mysql.sql as a seperate query. I just followed the convetion followed in th earlier sql statements. > On Feb. 22, 2017, 1:13 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql, > > line 265 > > <https://reviews.apache.org/r/56709/diff/1/?file=1634523#file1634523line265> > > > > add DEFAULT CHARSET=utf8 As we have provided the charset for PERM_CHANGE/PATH_CHANGE, I feel we don'r have to provide this again. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56709/#review166277 ----------------------------------------------------------- On Feb. 22, 2017, 11:38 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56709/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 11:38 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee > Yarlagadda, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding > missing files > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql > 0606116 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql > be9a33e > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql > 1c8848c > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql > fc7b53f > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql > ce807a5 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql > 3657377 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql > 5d88887 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql > b6108e7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql > d5b7d6e > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql > f0c8cfb > > Diff: https://reviews.apache.org/r/56709/diff/ > > > Testing > ------- > > Tested the scrips against db2, postgres, musql, oracle and derby databases. > > Also ran SchemaToll test for deby. > > > Thanks, > > kalyan kumar kalvagadda > >
