----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56481/ -----------------------------------------------------------
(Updated Feb. 23, 2017, 8:25 p.m.) Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. Changes ------- Addressed code review comments from Vadim Spector Bugs: SENTRY-1625 https://issues.apache.org/jira/browse/SENTRY-1625 Repository: sentry Description ------- SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder Diffs (updated) ----- sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java b1180bff1ce8850712e842e59e0e7217273ac59c sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGMPrivilege.java 55b61ac07c6865402ffe4d0ff1690afb435deb95 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 6dc6918314a11e343be281e86ecfa16ec4cf895a sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java PRE-CREATION sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7b926a5e546091881d4f7b4f30df4ae82dcd35b0 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 17a4a937221891a72ee44db92976cfa5cab40bc4 Diff: https://reviews.apache.org/r/56481/diff/ Testing ------- Thanks, Alexander Kolbasov