----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54798/ -----------------------------------------------------------
(Updated Feb. 28, 2017, 5:57 p.m.) Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector. Changes ------- Addressed review comments Bugs: SENTRY-1548 https://issues.apache.org/jira/browse/SENTRY-1548 Repository: sentry Description ------- Added code changes to SentryStore to have proper message (where the exceptions are originated). If this is done we can avoid decorating them later. I saw issue with exceptions created while role create/drop and made required changes. Diffs (updated) ----- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryAlreadyExistsException.java f29c42f sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryNoSuchObjectException.java 70719e4 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java 27dbfca sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7b926a5 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java b10c2f2 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java 3881c11 sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 9b986d7 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 0239388 Diff: https://reviews.apache.org/r/54798/diff/ Testing ------- I have performed tests using Sentrytool Client. Thanks, kalyan kumar kalvagadda