----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57375/#review169084 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java Lines 253 (patched) <https://reviews.apache.org/r/57375/#comment241401> You use ast.getChild(0)getCHild(0) several times - would it make sense to assign it to a variable with a meaningful name? - Alexander Kolbasov On March 7, 2017, 1:41 p.m., Yongzhi Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57375/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 1:41 p.m.) > > > Review request for sentry and Hao Hao. > > > Repository: sentry > > > Description > ------- > > Please review fix for SENTRY-1646. Fix the issue by getting the currOutDB > inform from qualified table name if exists. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > d269d5fe0bfd3e8638fcec15d426862f4f15ae35 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScopePart2.java > 8eb0bd69158805a3fbcb6c88d61b26ef922997ef > > > Diff: https://reviews.apache.org/r/57375/diff/1/ > > > Testing > ------- > > Add the test case in Unit test. > > > Thanks, > > Yongzhi Chen > >
