-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58166/#review170957
-----------------------------------------------------------




sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java
Line 96 (original)
<https://reviews.apache.org/r/58166/#comment243797>

    Not quite follow the change. If we are complete remove namespace here, why 
do we still keep the namespace config in HAContext? And why do we need it?


- Hao Hao


On April 4, 2017, 5:03 a.m., Alexander Kolbasov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58166/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 5:03 a.m.)
> 
> 
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, and Na Li.
> 
> 
> Bugs: SENTRY-1692
>     https://issues.apache.org/jira/browse/SENTRY-1692
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1692 ZK namespace configuration doesn't work
> 
> 
> Diffs
> -----
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java
>  00eec4eab066829ae1226d0ba3485eab7bd9eeb2 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java
>  1d79bd1f722505e56941dfd131d782e518515dc4 
> 
> 
> Diff: https://reviews.apache.org/r/58166/diff/1/
> 
> 
> Testing
> -------
> 
> I tested this manually by running the server with namespace provided in the 
> config.
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Reply via email to