> On April 4, 2017, 6:31 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 3167 (original), 3187 (patched) > > <https://reviews.apache.org/r/58069/diff/1/?file=1680728#file1680728line3187> > > > > Why do we change from 'Long' to 'long' here? it would result in extra > > unbox and autobox.
I did to get rid of IntelliJ warning about autoboxing of EMPTY_CHANGE_ID below. This isn't the usual case so we could ignore the warning, but when I checked usages it turns out that everyone is using getLastProcessedChangeIDCore() as long, so everyone unboxes anyway, so the net result is zero. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58069/#review170958 ----------------------------------------------------------- On March 30, 2017, 5:25 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58069/ > ----------------------------------------------------------- > > (Updated March 30, 2017, 5:25 a.m.) > > > Review request for sentry, Hao Hao and kalyan kumar kalvagadda. > > > Bugs: SENTRY-1670 > https://issues.apache.org/jira/browse/SENTRY-1670 > > > Repository: sentry > > > Description > ------- > > SENTRY-1670 Expose current HMS notification ID as a Sentry gauge (metric) > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > bbfa713262c5b4d5cecccd95c823a78c9149752c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java > 6ed2c781b4ac8819f6d17a249c33e32f0116e15a > > > Diff: https://reviews.apache.org/r/58069/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
