----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58093/#review171022 -----------------------------------------------------------
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java Line 137 (original), 135 (patched) <https://reviews.apache.org/r/58093/#comment243854> do you want to print out the value of "retries +1"? Does "retries + 1" gives you want you want? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java Line 322 (original), 319 (patched) <https://reviews.apache.org/r/58093/#comment243877> do you need to update testing cases in TestFullUpdateInitializer that verifies the exception type? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Line 303 (original), 303 (patched) <https://reviews.apache.org/r/58093/#comment243857> since you changed the possible exception, you need to update the commnet at line 303 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Line 310 (original), 310 (patched) <https://reviews.apache.org/r/58093/#comment243858> It would be easier to debug if you log the beginning of getting full snapshot. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Line 312 (original), 312 (patched) <https://reviews.apache.org/r/58093/#comment243859> My impression is that it takes some time to get the full snapshot. Should we measure the time it takes to get the full snapshot? And show the duration in the log message? - Na Li On March 31, 2017, 5:07 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58093/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 5:07 a.m.) > > > Review request for sentry, Lei Xu, Hao Hao, kalyan kumar kalvagadda, and Na > Li. > > > Bugs: SENTRY-1676 > https://issues.apache.org/jira/browse/SENTRY-1676 > > > Repository: sentry > > > Description > ------- > > SENTRY-1676: FullUpdateInitializer#createInitialUpdate should not throw > RuntimeExceptio > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java > 146cea2b9467ce82b69bbf402933b1aa350bcd46 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 6c14f5e46aad4223347d8d057188d31efbb68ed8 > > > Diff: https://reviews.apache.org/r/58093/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
