> On April 6, 2017, 12:41 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql > > Lines 5 (patched) > > <https://reviews.apache.org/r/58164/diff/4/?file=1685758#file1685758line5> > > > > Am I missing something? why is still using 008-xxx here? :) Also, again > > same as Sasha pointed out, I would prefer not to usea seperate sql script > > file to update the new table no one is using yet. > > > > BTW, did you get a chance to verify those changes?
I have tested it against all 5 databases that sentry offically suppports. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171184 ----------------------------------------------------------- On April 7, 2017, 9:56 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58164/ > ----------------------------------------------------------- > > (Updated April 7, 2017, 9:56 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li. > > > Bugs: SENTRY-1638 > https://issues.apache.org/jira/browse/SENTRY-1638 > > > Repository: sentry > > > Description > ------- > > UpdateD SQL script of MSentryPathChange table to add a column for > notification ID. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > e981bcf0f327346c09cdbe5785fb8824fc62e704 > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql > 1829e2fa1f02a4339e7af4bf45a169013e9ec65f > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql > 84b7903857ba51badde8a769eae86219eeaf3dab > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql > 69865508103bb8b1dd6148aa48c616d4b683614f > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql > 6a438ea847619af4d4d99d0fb99e036e55bf425f > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql > a9b7e2c48bb86bc0a81fad00d27387e26ef18c28 > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql > 547bbe8136186658e7fe76ab24934157ea5300ff > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql > 6474389a18ea59da28d3d7125cf227c7aaa7f7aa > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql > 1ab83432db233ee4e7aa054adc1b82c26248a099 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql > 0418b298f7cbd8f430733cb329e9fca263bda0f7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql > 68d2c8d53d7c468269ca2c41986ef8651b94f5c7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql > 5376c166659b3e8e373c8c20818f5b1290af90c9 > > > Diff: https://reviews.apache.org/r/58164/diff/7/ > > > Testing > ------- > > I have tested it against derby, oracle, postgres, mysql and db2. > > > Thanks, > > kalyan kumar kalvagadda > >
