----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172104 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 107 (patched) <https://reviews.apache.org/r/58221/#comment245179> Please add comment explaining how do you use the future. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 282 (patched) <https://reviews.apache.org/r/58221/#comment245181> Please add clarifying parenthesis: if (notificationLogEnabled && (hmsFollowerExecutor == null) && (hmsFollower != null)) { sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 292 (patched) <https://reviews.apache.org/r/58221/#comment245183> We can't handle this - if HMSFollowert should start and it doesn't, SentryService should fail. The easiest thing may be just to propagate the exception up the chain. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 343 (patched) <https://reviews.apache.org/r/58221/#comment245184> You can move this outside the try block and return immediately if storeCleanPeriodSecs <= 0. This will simplify the code a bit. - Alexander Kolbasov On April 17, 2017, 5:55 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 17, 2017, 5:55 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > > Diff: https://reviews.apache.org/r/58221/diff/12/ > > > Testing > ------- > > > Thanks, > > Na Li > >
