Hi Alex, I changed MPath class to include pathID to have correct MPath equality comparison. Since the original equals() definition only compares 'path' which for different MPath object it may have the same value.
For pathID (primary key) assignment I change it to be auto-increment by specifying value-strategy to be "increment ". Please let me know if you think any of the change is not reasonable. Thanks! Best, Hao On Wed, Apr 19, 2017 at 11:37 AM, Alexander Kolbasov <ak...@cloudera.com> wrote: > Hao, > > Can you clarify the changes you propose for MPath class and related > package.jdo changes for SENTRY-1587? > > You suggest changing the identity type from "database" to "application", > but the pathId is not initialized in constructor and not assigned anywhere. > What is your intention here? > > Also you changed the equals() method to include ID. What kind of equality > do you require - equality by path value or equality by identity? What is > your thinking here? > > This is in regards to the code review https://reviews.apache.org/r/58412. > > Thanks, > > - Alex >
