> On May 8, 2017, 11:21 p.m., Alexander Kolbasov wrote:
> > I don't see how the fix would actually help - the only way for HMSFollower
> > to make forward progress is to update notification IDs - otherwise it will
> > process the same event over and over and continue failing.
right now, In HMSFollower constructor, we get event ID (currentEventID) from
data base ("currentEventID = getLastProcessedNotificationID();") In each run(),
the currentEventID in memory is advanced after processing each notification
event and used to get new notifications from meta store.
This fix makes sure currentEventID advances even when having exception at
processing the notification event. So it won't stuck. sentry-1669 and
sentry-1726 will save currentEventID into DB after processing, and read
currentEventID from DB before processing.
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59058/#review174239
-----------------------------------------------------------
On May 8, 2017, 6:07 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59058/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 6:07 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar
> kalvagadda, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: sentry-1752
> https://issues.apache.org/jira/browse/sentry-1752
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Catch exception in processing notification event and move on. Add unit test
>
>
> Diffs
> -----
>
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
> e271ea4
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java
> fd97936
>
>
> Diff: https://reviews.apache.org/r/59058/diff/1/
>
>
> Testing
> -------
>
> add unit test
>
>
> Thanks,
>
> Na Li
>
>
