----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59132/#review174495 -----------------------------------------------------------
Ship it! Same comment as Sergio's. Using "try-with-resources" seems like a good idea. - Vamsee Yarlagadda On May 10, 2017, 7:48 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59132/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 7:48 a.m.) > > > Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Na Li, Vamsee > Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1759 > https://issues.apache.org/jira/browse/SENTRY-1759 > > > Repository: sentry > > > Description > ------- > > SENTRY-1759 UpdatableCache leaks connections > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > f272630171763b8afa2cbd826cb2004532e52a4a > > > Diff: https://reviews.apache.org/r/59132/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
