----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59252/#review174878 -----------------------------------------------------------
Fix it, then Ship it! Looks good to me, but as we discussed, the only way to verify how well this works is to run the updated code, take another heap dump and check that it for duplicate strings. sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java Lines 449 (patched) <https://reviews.apache.org/r/59252/#comment248106> You probably want to remove this method and use MSentryUtil.safeIntern() in this class instead? - Misha Dmitriev On May 13, 2017, 1:48 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59252/ > ----------------------------------------------------------- > > (Updated May 13, 2017, 1:48 a.m.) > > > Review request for sentry, Brian Towles, Misha Dmitriev, Hao Hao, kalyan > kumar kalvagadda, Na Li, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1758 > https://issues.apache.org/jira/browse/SENTRY-1758 > > > Repository: sentry > > > Description > ------- > > SENTRY-1758 Improve Sentry memory usage by interning object names > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java > 2fe2bb5b95200c54445611e200492bfa157e2eaa > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > c710701e06921c5ee85cda5c11021384aeb4053f > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MPath.java > c74384688ca920c79fb2987d225042e135cdfd53 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGMPrivilege.java > 749af2a3e9d0420d3597952b0fcf13578f16a52f > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGroup.java > 7e41c93294c64dd50b5672ca6fa3e003955ed365 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java > 4c3af7992c90ba6ce33ff38ca6c5a3eb3492dd8b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java > f9da589d8de78bd4f8cb820bd7f545241000c417 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > ff5724999531fe4c1c6ccf8e206ee695749661c4 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryVersion.java > ff8830f11a4f53801babbc0bb5deb386cfcbab42 > > > Diff: https://reviews.apache.org/r/59252/diff/2/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
