> On May 15, 2017, 7:32 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 458 (patched) > > <https://reviews.apache.org/r/59282/diff/1/?file=1718515#file1718515line458> > > > > can you move the check inside stopHMSFollower(conf)? > > Also, need to check if hmsFollower is null to decide skip the > > processing or not to avoid the scenario that hmsFollower was started, and > > then configuration has changed.
I didn't understand the second part. How can the hmsFollower being started if the condition does not allow that? Is there any other method that could start the hmsFollower? The configuration cannot be changed during the startHMSFollower. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59282/#review175007 ----------------------------------------------------------- On May 15, 2017, 6:38 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59282/ > ----------------------------------------------------------- > > (Updated May 15, 2017, 6:38 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Na Li. > > > Bugs: SENTRY-1716 > https://issues.apache.org/jira/browse/SENTRY-1716 > > > Repository: sentry > > > Description > ------- > > The patch just avoids starting HMSFollower if HDFS sync is disabled. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 6fb224c4861ad030af5a4f543fa26e67138a6275 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > 4019e61af9d00ae1c3a78025297e9ebbe5c9de00 > > > Diff: https://reviews.apache.org/r/59282/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
