-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59120/#review174981
-----------------------------------------------------------




sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 201 (patched)
<https://reviews.apache.org/r/59120/#comment248286>

    metastoreUri is already avaialble . You need not get it once again from the 
hive conf.



sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java
Lines 157 (patched)
<https://reviews.apache.org/r/59120/#comment248458>

    Current comment is misleading. Please correct it and explain in the 
comment, reason for increasing the wait time.


- kalyan kumar kalvagadda


On May 12, 2017, 3:40 a.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59120/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 3:40 a.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and 
> Sergio Pena.
> 
> 
> Bugs: sentry-1757
>     https://issues.apache.org/jira/browse/sentry-1757
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> use hive configuration to check.
> 
> 
> Diffs
> -----
> 
>   
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java
>  431c7fe 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  9880c40 
>   
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java
>  1530eb2 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
>  7d128b7 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
>  32acc65 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
>  548dcf8 
> 
> 
> Diff: https://reviews.apache.org/r/59120/diff/5/
> 
> 
> Testing
> -------
> 
> integration test TestHDFSIntegrationEnd2End
> 
> 
> Thanks,
> 
> Na Li
> 
>

Reply via email to