----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59241/#review175472 -----------------------------------------------------------
Ship it! Ship It! - Alexander Kolbasov On May 19, 2017, 4:35 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59241/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 4:35 a.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, kalyan > kumar kalvagadda, and Sergio Pena. > > > Bugs: SENTRY-1705 > https://issues.apache.org/jira/browse/SENTRY-1705 > > > Repository: sentry > > > Description > ------- > > check if metastore uri is configured or not. If not, don't create HMSFollower. > > This code change is base on assumption that code change in > https://reviews.apache.org/r/59120/diff/5#1 is checked in (hive configuration > is available when sentry server starts). Otherwise, it may break tests since > in test, hive configuration is not available when sentry server starts. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 5dc0ad3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 35289aa > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > 9470437 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > e2fb36a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java > 0ca7704 > > > Diff: https://reviews.apache.org/r/59241/diff/4/ > > > Testing > ------- > > > Thanks, > > Na Li > >
