----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59414/#review175567 -----------------------------------------------------------
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java Line 183 (original), 185 (patched) <https://reviews.apache.org/r/59414/#comment248959> I read that the scheduled thread guarantees that this run() is executed sequeantially, and no other tasks will be run at the same time. How is another thread scheduled to run at the same time? Do we have test cases that prooves this? sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java Lines 217 (patched) <https://reviews.apache.org/r/59414/#comment248958> If the thread is scheduled to be run in 500ms (refreshIntervalMillisec), how is this waitUtil going to work? I think this line is not needed as run() will be run in 500ms and the waitUntil will be already valid at that time. - Sergio Pena On May 19, 2017, 6:56 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59414/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 6:56 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, Sergio Pena, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1771 > https://issues.apache.org/jira/browse/SENTRY-1771 > > > Repository: sentry > > > Description > ------- > > when curent time < wait until, return instead of sleeping. This avoid 6 > concurrent requests for full snapshot from HDFS. > Also synchronize the function SentryAuthorizationInfo.update() to make sure > requests always contain the latest changeID > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > 90ba721 > > > Diff: https://reviews.apache.org/r/59414/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
