> On May 24, 2017, 3:23 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 268 (patched) > > <https://reviews.apache.org/r/59510/diff/1/?file=1730921#file1730921line272> > > > > Is it possible that before previous full update request is returned, > > another full update request is sent? > > Vamsee Yarlagadda wrote: > There is only one thread processing the HMSFollower right. If that's the > case, there shouldn't be multiple snapshot requests pending.
As, Executors for HMSFollower has only one thread, this will not be possible. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/#review175939 ----------------------------------------------------------- On May 25, 2017, 1:41 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59510/ > ----------------------------------------------------------- > > (Updated May 25, 2017, 1:41 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1774 > https://issues.apache.org/jira/browse/SENTRY-1774 > > > Repository: sentry > > > Description > ------- > > HMSFollower should always depend on persisted information to decide is full > snapshot is needed instead of depending on in-memory information. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 8450402 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 58e8881 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 440b0e9 > > > Diff: https://reviews.apache.org/r/59510/diff/2/ > > > Testing > ------- > > Added new test to check new functionality added and also ran HMSFollower tests > > > Thanks, > > kalyan kumar kalvagadda > >
