----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58536/#review176966 -----------------------------------------------------------
Fix it, then Ship it! sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/transport/testSentryHDFSClientTransportConfig.java Lines 30 (patched) <https://reviews.apache.org/r/58536/#comment250504> Test class for SentryHDFSClientTransportConfig sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/transport/testSentryHDFSClientTransportConfig.java Lines 35 (patched) <https://reviews.apache.org/r/58536/#comment250503> Classes should start with CamelCase. sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/transport/testSentryPolicyClientTransportConfig.java Lines 35 (patched) <https://reviews.apache.org/r/58536/#comment250505> Same comment as above. CamelCase - Vamsee Yarlagadda On April 19, 2017, 4:40 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58536/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 4:40 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1678 > https://issues.apache.org/jira/browse/SENTRY-1678 > > > Repository: sentry > > > Description > ------- > > Added test classes to test the implmentations of > SentryClientTransportConfigInterface for policy and hdfs configuraitons. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/transport/testSentryHDFSClientTransportConfig.java > PRE-CREATION > > sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/transport/testSentryPolicyClientTransportConfig.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58536/diff/1/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
