----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59862/#review177131 -----------------------------------------------------------
Fix it, then Ship it! sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java Line 77 (original), 77 (patched) <https://reviews.apache.org/r/59862/#comment250679> Plese remove this comment - it doesn't make much sense sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java Line 69 (original), 69 (patched) <https://reviews.apache.org/r/59862/#comment250680> Please remove this comment. - Alexander Kolbasov On June 7, 2017, 12:07 a.m., Lei Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59862/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 12:07 a.m.) > > > Review request for sentry and Alexander Kolbasov. > > > Bugs: SENTRY-1795 > https://issues.apache.org/jira/browse/SENTRY-1795 > > > Repository: sentry > > > Description > ------- > > Previously we change to rely on ORM and database to auto assign primary key, > which will leave holes between keys. SENTRY-1792 explains how we can have > holes in the delta tables. We should plug these holes. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java > d11f37f0157f96b900917d946d05d6b11eeee582 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java > 1cb1a1f00fd7b8c5af49ec5c8bd5c7cdcd5e3a59 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 96ab462d22afaf0f3004926f2855a8bb8cabc53b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java > 77282da910a16ab5c77575022722988c4fa05073 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 23b685be1f96814dd580d8ae5eac610c0523e0fa > > > Diff: https://reviews.apache.org/r/59862/diff/2/ > > > Testing > ------- > > mvn test -Dtest=TestSentryStore#testConcurrentUpdateChanges > > Passed on my laptop. > > > Thanks, > > Lei Xu > >
