> On June 28, 2017, 8:47 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java > > Lines 298 (patched) > > <https://reviews.apache.org/r/60490/diff/1/?file=1765924#file1765924line298> > > > > The run() is called at fixed rate. path is from configuration. So each > > write should append the content in tmpPath to the existing file. > > > > fs.rename seems to use new metric to replace existing one. > > If path exists, will "fs.rename(tmpPath, path)" succeed?
Yes, it is not append. On every iteration a new temp file is created and moved to the destination file. I verified that it works as advertised. The code is an adaptation from Hive. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60490/#review179168 ----------------------------------------------------------- On June 28, 2017, 5:56 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60490/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 5:56 a.m.) > > > Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, > Sergio Pena, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1820 > https://issues.apache.org/jira/browse/SENTRY-1820 > > > Repository: sentry > > > Description > ------- > > SENTRY-1820: Add JSON file reporter for Sentry metrics > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java > e3691a96ef1142fdae74ba873683a025265cc006 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > d3c96fafc262ca7cfc3ba97ea24c715ab0b129ac > > > Diff: https://reviews.apache.org/r/60490/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
