----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60669/#review179889 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 549 (patched) <https://reviews.apache.org/r/60669/#comment254789> should the condition to be "changesToKeep > 0"? You want to keep at least one entry there, right? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 599 (patched) <https://reviews.apache.org/r/60669/#comment254790> do you need to log this as info instead of debug? purgeNotificationIdTableCore has logged the purged result as info sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 607 (patched) <https://reviews.apache.org/r/60669/#comment254791> same thing here sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 3790 (patched) <https://reviews.apache.org/r/60669/#comment254792> usually, the function ends with "core" if it deals with jdo directly. Can you follow the same convention? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java Lines 242 (patched) <https://reviews.apache.org/r/60669/#comment254793> what is the reason to keep large number of entries in this table? We only need the entry with the largest ID. - Na Li On July 5, 2017, 11:10 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60669/ > ----------------------------------------------------------- > > (Updated July 5, 2017, 11:10 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1762 > https://issues.apache.org/jira/browse/SENTRY-1762 > > > Repository: sentry > > > Description > ------- > > SENTRY_HMS_NOTIFICATION_ID table will be updated with the ID's for every > notification that sentry processes. This data grows with time. > we need to periodically purge this data as it will effect the performance. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 1402ab1 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > ec938da > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 83f00ca > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > ac266fe > > > Diff: https://reviews.apache.org/r/60669/diff/1/ > > > Testing > ------- > > Added new tests to test the code change added. > > > Thanks, > > kalyan kumar kalvagadda > >
