> On July 17, 2017, 4:51 p.m., Brian Towles wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HmsFollower.java > > Line 214 (original), 225 (patched) > > <https://reviews.apache.org/r/60883/diff/1/?file=1777189#file1777189line226> > > > > Needed for public function? or should this be a public function?
It has to be public function, so in org.apache.sentry.provider.db.service.persistent.TestHMSFollowerSentryStoreIntegration, I can call it. SentryStore and HmsFollower are in different folder, so some functions have to be public. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60883/#review180688 ----------------------------------------------------------- On July 17, 2017, 9:04 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60883/ > ----------------------------------------------------------- > > (Updated July 17, 2017, 9:04 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Sergio Pena, and Vamsee > Yarlagadda. > > > Repository: sentry > > > Description > ------- > > There are several problems: > 1) HMSFollower should read sentry-site.xml to get the authen server name, not > from hive-site.xml through hiveConf. The input configuration for HMSFollower > constructor is from sentry-site.xm. We should use that configuration to get > server name. > 2) There are two variable names that could hold the value of the server. > "hive.sentry.server"is deprecated and is in > HiveAuthzConf.AuthzConfVars.AUTHZ_SERVER_NAME_DEPRECATED. The new name is > sentry.hive.server in HiveAuthzConf.AuthzConfVars.AUTHZ_SERVER_NAME. We > should check the sentry.hive.server first. If it is not set, check the > deprecated hive.sentry.server to be backward compatible. If it is still not > set, use default value > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-conf/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > 4de755f > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzConf.java > dccbbb6 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveSimpleConnectionFactory.java > 3d67401 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HmsFollower.java > a9d05b1 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHmsFollower.java > 2095469 > > > Diff: https://reviews.apache.org/r/60883/diff/2/ > > > Testing > ------- > > create integration tests. reproduced the issue and verfied the fix > > > Thanks, > > Na Li > >
