-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60926/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na
Li.
Bugs: sentry-1760
https://issues.apache.org/jira/browse/sentry-1760
Repository: sentry
Description
-------
The patch will set the 'requestHmsSnapshot' to TRUE whenever the following
cases are found:
* List of notifications received are different than expected.
This may happen when Sentry has been down or HDFS sync was disabled for a
while (more than 24h),
and the HMS cleared old notifications (older than 24h) not processed by
Sentry causing a gap when retrieving notifications.
* Latest Sentry notification ID processed is bigger than current HMS
notification ID.
This may happen when the HMS DB data was reset or restore from an old
snapshot causing sync issues with Sentry.
New snapshots are persisted with a new generation ID (or image number), so
there's is no need to clean-up older snapshots.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HmsFollower.java
a9d05b1f24823c79ab6d37a07b60a7e3b30f2b3c
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHmsClient.java
29a85d7181b52937e16028baf71ee5528bbd48d1
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHmsFollower.java
2095469ae16ad918347a31d76bc5f22e12b8f4c3
Diff: https://reviews.apache.org/r/60926/diff/1/
Testing
-------
Added test cases on TestHmsFollower
Thanks,
Sergio Pena
