> On July 24, 2017, 3:54 p.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/LogLevelServlet.java > > Lines 32 (patched) > > <https://reviews.apache.org/r/60955/diff/1/?file=1778962#file1778962line32> > > > > Why is the size specified in the code? Is it the standard practice? > > Donghui Xu wrote: > I have tested. When the length of input text is 50, user can enter 45 > characters which meet the requirements.
We can enter class names here - do we know that all class names fit 45 characters? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60955/#review181217 ----------------------------------------------------------- On July 26, 2017, 2:28 a.m., Donghui Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60955/ > ----------------------------------------------------------- > > (Updated July 26, 2017, 2:28 a.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Na Li. > > > Bugs: SENTRY-1853 > https://issues.apache.org/jira/browse/SENTRY-1853 > > > Repository: sentry > > > Description > ------- > > Add the log level setting and reading mechanism, through which users can > control the log content. > This mechanism provides the url interface,through which users can dynamically > set the log level. Service restores the original log level after restart. > > The format of the interface is as follows: > 1. Read the log level. URL address is http: //HOST: PORT/logLevel? Log = > CLASS_NAME > 2. Set the log level. URL address is http: //HOST: PORT/logLevel? Log = > CLASS_NAME & level = LOG_LEVEL > > The above parameters include: > HOST: host name or ip address of sentry server. > PORT: port of sentry server. > CLASS_NAME: name of class whose log level is read or set. > LOG_LEVEL: the log level to be set. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/LogLevelServlet.java > PRE-CREATION > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java > 8b4d374 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerLogLevel.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60955/diff/2/ > > > Testing > ------- > > > Thanks, > > Donghui Xu > >
