> On July 27, 2017, 9:52 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 68 (original), 69 (patched) > > <https://reviews.apache.org/r/61047/diff/3/?file=1784509#file1784509line69> > > > > This file deals with Generic permissions model which is never subject > > to HDFS sync. > > Na Li wrote: > Initially, I have SentryStore(Configuration conf), and caller does not > need to care about HDFS sync. SentryStore finds out through configuration. > You did not want SentryStore to figure it out. So I changed the constructor > to take it as input. > > Now, you don't want caller to provide the value. What should I do? > > Do you mean I should provide two constructors for SentryStore, > SentryStore(Configuration conf) (SentryStore finds out the value from > configuration) and SentryStore(Configuration conf, boolean saveDeltaChange)? > > Can you be more specific about what you want? Otherwise, it will take too > long to close this issue.
Option 1) Have two constructors for SentryStore. One constructor just accepts conf and always disables saving permission deltas. Another constructor has a parameter that tells whether it should be enabled or not. This cnstructor should be only used for Policy (Hive) permissions. Option 2) Do not change constructor, but add a setter in SentryStore which sets the boolean value asking it to persist permission deltas. This setter should only be called by policy store engine. This is probably best. > On July 27, 2017, 9:52 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 171 (patched) > > <https://reviews.apache.org/r/61047/diff/3/?file=1784510#file1784510line171> > > > > This is a very confusing name What is saveDeltaBlockEnabled? It should > > be at least documented, but a better name would be good. > > Na Li wrote: > What is the name you prefer? How about 'persistUpdateDeltas' ? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61047/#review181612 ----------------------------------------------------------- On July 27, 2017, 3:57 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61047/ > ----------------------------------------------------------- > > (Updated July 27, 2017, 3:57 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, > Sergio Pena, and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Currently, Sentry does not start HMSFollower when HDFS sync is disabled. This > breaks PERM sync. For example, when a table/database is dropped, its > permission should be removed when perm sync is enabled. Without HMSFollower, > Sentry does not know when table/database is dropped, and therefore, cannot > remove the permission accordingly. > Sentry needs to make updates to have the follow behavior > 1) When HDFS sync is disabled + PERM sync is disabled, do not start > HMSFollower > 2) when HDFS sync is enabled or PERM sync is enabled, start HMSFollower > (Sentry change). > 3) when HDFS sync is enabled, we save path change and perm change. nothing > more. > 4) when perm sync is enabled, we update perm when table/database is created, > dropped or altered, nothing more. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > 4cb46ab > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 670bc5e > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryAdminServlet.java > 8a8bbd3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 10d55dc > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > 5826766 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java > 82f600b > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > a8ebf7c > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java > 1c3a4f2 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java > a8e8a03 > > > Diff: https://reviews.apache.org/r/61047/diff/3/ > > > Testing > ------- > > unit tests > > > Thanks, > > Na Li > >
