----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61724/ -----------------------------------------------------------
(Updated Aug. 18, 2017, 3:32 p.m.) Review request for sentry, Brian Towles, Sergio Pena, and Vamsee Yarlagadda. Repository: sentry Description ------- when deciding if we should take full snapshot of HMS, check notification table intead of the authorization path table because notification table is always updated regardless HDFS is enabled or not In HMSFollower.createFullSnapshot(), you can see the notification ID is saved into data store regardless HDFS is enabled or not. Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java e9de73a sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 1d8200d sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 2d6b92a sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java 48b009f Diff: https://reviews.apache.org/r/61724/diff/2/ Changes: https://reviews.apache.org/r/61724/diff/1-2/ Testing ------- unit tests Thanks, Na Li
