> On Aug. 22, 2017, 8:31 p.m., Alexander Kolbasov wrote: > > Would it make sense to still handle the old config if it is present and the > > new one isn't? > > Vamsee Yarlagadda wrote: > For the fact that we are releasing a new major version of Sentry, I think > it is safe for us to break the compatibility in that aspect and make the code > simpler by simply referring only to the new property. Thoughts?
Will file a seperate jira to track this. As the first step will make both upstream and downstream in sync. - Vamsee ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61821/#review183518 ----------------------------------------------------------- On Aug. 22, 2017, 6:57 p.m., Vamsee Yarlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61821/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2017, 6:57 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Na Li. > > > Repository: sentry > > > Description > ------- > > SENTRY-1897: Rename sentry property to provide the list of sentry servers > > > Diffs > ----- > > conf/sentry-site.xml.hive-client.example > c9f1d0588c99c7815c5a7f35382e32ef73116e78 > conf/sentry-site.xml.hive-client.template > becff9c6aa8c2ea5afa6979f271ec61e79b36c1f > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java > fd07887963b4ac0f6e1243df774c87e843fed29b > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java > f99301008ca1a0fd9efce4131c037436dccfdb2c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 5b6ef53b8f79d64c0f791fabb6b6fee86c895c67 > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > c19ccbd12fde3567496b6847cf2b67b3c49cd655 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > e62c54a5c0a932617a88492944a6d9fb76571903 > > > Diff: https://reviews.apache.org/r/61821/diff/1/ > > > Testing > ------- > > Will make sure all the unit tests work. > > > Thanks, > > Vamsee Yarlagadda > >
