> On Aug. 22, 2017, 10:12 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 1836-1841 (patched) > > <https://reviews.apache.org/r/61823/diff/1/?file=1801866#file1801866line1836> > > > > Looks like we are having the actual SQL here. Do you think this would > > the way datanucles talking with various DB's? I mean will the syntax works > > on every DB or should we explore some datanuclues specific syntax for > > handlings joins?
that's a fair point. I can test on my cluster with Oracle and a few others and see how it works. Investigating a DataNucleus with JOIN approach might also help, but I couldn't find datanucleus specifc syntax for joins (so far). - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61823/#review183540 ----------------------------------------------------------- On Aug. 22, 2017, 9:58 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61823/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2017, 9:58 p.m.) > > > Review request for sentry, Alexander Kolbasov, Vamsee Yarlagadda, and Vadim > Spector. > > > Repository: sentry > > > Description > ------- > > Right now when we get privileges from sentry, we pass in a provider like set > of groups. Then we create a MSentryGroup object for each group and then get > roles using the .getRoles() method. However, DataNucleus takes too long and > the fetch doesn't seem to be lazy. This is bad since we only need the > roleNames for the group and not the entire Role object. > Instead running a SQL like query and just getting roleNames will drastically > improve performance > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > d7acaea7c > > > Diff: https://reviews.apache.org/r/61823/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
