----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61858/#review183653 -----------------------------------------------------------
We get all path changes via notifications. DOes this match the way notifications are defined in HMS? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo Line 302 (original), 302 (patched) <https://reviews.apache.org/r/61858/#comment259721> Is there any reason not to do this for permission changes? sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql Line 16 (original), 16 (patched) <https://reviews.apache.org/r/61858/#comment259722> Do we need mediumtext? Would TEXT (64K max) be sufficient? sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql Line 17 (original), 17 (patched) <https://reviews.apache.org/r/61858/#comment259723> Would VARCHAR2 work here? - Alexander Kolbasov On Aug. 23, 2017, 7:46 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61858/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2017, 7:46 p.m.) > > > Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vamsee > Yarlagadda. > > > Repository: sentry > > > Description > ------- > > change sql schema to allow path_change contain larger value > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 77ec491 > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql > 4afa2e0 > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql > 8636fec > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql > c3c374b > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql > d168bf5 > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.0.0.sql > 69ef5b7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.0.0.sql > 0db7ba9 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql > 183481a > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.0.0.sql > cf4f0ed > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.0.0.sql > 5974ed9 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-2.0.0.sql > 20c50b7 > > > Diff: https://reviews.apache.org/r/61858/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
