----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61889/#review183881 -----------------------------------------------------------
Fix it, then Ship it! Ship It! sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java Line 110 (original), 119 (patched) <https://reviews.apache.org/r/61889/#comment259945> Can we just use hash as the hashcode and skip the rest? It already incorporates the rest sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java Line 138 (original), 147 (patched) <https://reviews.apache.org/r/61889/#comment259946> Since hashCode incorporates the rest we can just return true here - Alexander Kolbasov On Aug. 25, 2017, 8:34 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61889/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2017, 8:34 p.m.) > > > Review request for sentry, Alexander Kolbasov and Na Li. > > > Bugs: sentry-1895 > https://issues.apache.org/jira/browse/sentry-1895 > > > Repository: sentry > > > Description > ------- > > Added two indexes to the NOTIFICATION_ID columns on the following tables: > - SENTRY_HMS_NOTIFICATION_ID (non-unique index) > - SENTRY_PATH_CHANGE (unique index) > > Calculate the sha1 hex string on the MSentryPathChange and persist it. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UniquePathsUpdate.java > PRE-CREATION > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDeltaRetriever.java > 7ea75a093f49f00cefec67ae3884dfc82650f700 > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceProcessor.java > f2368b7d2be8b8926ba31562bf7d3493f7d36378 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java > 58878e55a23936bc0a2f15fa33883e655b255640 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 734ea7fd214cd577bf456cc84d27949ee332a468 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java > 4fe62bf7ac4a1bde84836d7e65ac6069751aceac > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > d7acaea7c32c34131c3f9d5ed85b0b12244b0f1d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java > 9e28da4d96c873afad7279e6f75cd6a31627b7b1 > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql > 019b0406291f5143b92aa9b678c528da58db1602 > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql > a0223dc09046048582f395e8bd8e41cd73f462be > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql > 733cebfdf78d03c808a2c8ae04476669bd285416 > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql > cd7afd4e3afb9aededd07506f82b43055abc2254 > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.0.0.sql > 44124c6d77c2e6c4185e4ef306ff4fbc20b5527b > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.0.0.sql > 3a7b46ee246d3347d371261a4bf727da4fb163fc > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql > 7475a5de88abc267b39d7fafa48fd0b14c94d31b > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.0.0.sql > 20c4cd99b7933f612231afac938fba03632258d2 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.0.0.sql > 794ff1778efb30468a5b7a23471fc71e99d42ab4 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-2.0.0.sql > 065921e3e637ee78c1a118bf3e05a0af9a1d602e > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/model/TestMSentryUtil.java > 6ff79f86f9aa3c8e0e840686a03d610a9fde6f01 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 8f60b5801b5f481bc3d225a64f411f1867aed141 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java > c5fedfc69454ccbd56e207a3bd5b43f62b298b54 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestNotificationProcessor.java > 0fd4ff0c8fea16fad0a78d42c2e7fe288361fec4 > > > Diff: https://reviews.apache.org/r/61889/diff/3/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
