> On Aug. 28, 2017, 5:03 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Line 135 (original), 126 (patched) > > <https://reviews.apache.org/r/61793/diff/2/?file=1803982#file1803982line135> > > > > Is this something that we are matching with the size on Hive side? > > Otherwise this could lead into lot of problems. > > Na Li wrote: > Sergio raised the same concern. We are not matching the size of Hive > side. This change only match the datanucleus size with the size in SQL script > at Sentry.
now, the size is the same at hive, sentry package.jdo and sentry sql scripts. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/#review183954 ----------------------------------------------------------- On Aug. 28, 2017, 11:09 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61793/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2017, 11:09 p.m.) > > > Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vamsee > Yarlagadda. > > > Repository: sentry > > > Description > ------- > > reduce field size `SERVER_NAME`,`DB_NAME`,`TABLE_NAME`,`COLUMN_NAME` in > `SENTRY_DB_PRIVILEGE` from 4000 to 128, and remove `URI` from being part of > the unique id > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 734ea7f > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-1894.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-1894.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-1894.postgres.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql > 7475a5d > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.0.0.sql > 20c4cd9 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.0.0.sql > 794ff17 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-2.0.0.sql > b6d9d05 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-2.0.0.sql > bf4754f > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-2.0.0.sql > 6f4c606 > > > Diff: https://reviews.apache.org/r/61793/diff/3/ > > > Testing > ------- > > run datanucleus schema tool. Without this change, it complains > "com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Specified key was > too long; max key length is 767 bytes. > After those change, the datanucleus schema tool finishes successfully with > command "mvn datanucleus:schema-create -X -e" > > > Thanks, > > Na Li > >
