----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61973/#review184333 -----------------------------------------------------------
Ship it! Ship It! - Alexander Kolbasov On Aug. 31, 2017, 6:13 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61973/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2017, 6:13 p.m.) > > > Review request for sentry, Alexander Kolbasov and Na Li. > > > Bugs: sentry-1888 > https://issues.apache.org/jira/browse/sentry-1888 > > > Repository: sentry > > > Description > ------- > > Approach: > The proposed solution will be to request notifications from the last ID seen > again. This way we could bring current duplicates and apply them on Sentry. > We have the risk to miss duplicates that were committed much time later, but > we cannot trust on those duplicates as they will not know the order of the > time they were committed. > > The patch adds a new helper class called HiveNotificationFetcher that allow > us to bring new notifications and apply a filter to those notifications that > were already processed by Sentry. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UniquePathsUpdate.java > 7dae2f538602f4c264084791fb45bb6891a34941 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 593b92f96b47f959266280bce3d0809f6a80c362 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 35da6fc7908ec7498d1fd658d75b62028df35751 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java > 4a8fb953ce486e1aeb1042884de56872b5539cd0 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java > f56384a99e128b3e9880cbc5692107d61f2f500f > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHiveNotificationFetcher.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestSentryHMSClient.java > 77a2bbb214e23ca146c2934ee4d3bf15e592906f > > > Diff: https://reviews.apache.org/r/61973/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
