----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62112/#review184689 -----------------------------------------------------------
Should we do the same change on PermImageRetriever as well? It is doing the same thing as PathImageRetriever. sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java Line 86 (original) <https://reviews.apache.org/r/62112/#comment260876> Should we keep these metrics here? sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceProcessor.java Line 54 (original), 56 (patched) <https://reviews.apache.org/r/62112/#comment260877> If we return an empty PathsUpdate here, then we can enable this test. sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceProcessor.java Line 80 (original), 83 (patched) <https://reviews.apache.org/r/62112/#comment260878> If we return an empty PathsUpdate here, then we can enable this test. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 2689 (patched) <https://reviews.apache.org/r/62112/#comment260879> Any tests needed on TestSentryStore for this? - Sergio Pena On Sept. 6, 2017, 7:19 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62112/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 7:19 a.m.) > > > Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1915 > https://issues.apache.org/jira/browse/SENTRY-1915 > > > Repository: sentry > > > Description > ------- > > SENTRY-1915 Sentry is doing a lot of work to convert list of paths to > HMSPaths structure > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java > 719c1acc18ce627f5228efb0d9cf47a7b5810a1b > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java > cbdc7ecdbeee0825b57b0c4408e0600f601a166c > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > 1762ee5fd21bb49f6593c2f0a0cc5810bfc4b8dd > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java > 1bdebb13b4cf981f0d69d93574a3ba317d9822ba > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceProcessor.java > 4652dc9e0a35a20780418d8e388595198a8f9ccd > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 83340342851598caf86f7c9e8e4d79f0e6027b20 > > > Diff: https://reviews.apache.org/r/62112/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
