----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62136/#review184752 -----------------------------------------------------------
Fix it, then Ship it! Ship It! sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Line 191 (original), 191 (patched) <https://reviews.apache.org/r/62136/#comment260957> Since we are not doing anything fancy now, should we just remove this and have a simple catch-all? - Alexander Kolbasov On Sept. 6, 2017, 10:50 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62136/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 10:50 p.m.) > > > Review request for sentry, Alexander Kolbasov and Vamsee Yarlagadda. > > > Bugs: sentry-1928 > https://issues.apache.org/jira/browse/sentry-1928 > > > Repository: sentry > > > Description > ------- > > The patch is closing the HMS connections on the HiveNotificationFetcher if > any Exception occurrs. The HMSFollower has also code to close the connection > on any Exception, but I do it for legacy reasons as I think it is not > required anymore. The HMSFollower needs some refactoring, though. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > d4feb380fa0f3bd5f237609a107295a2d23eae3b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > 4d329921bb4bc540992084687726155cb0373f0f > > > Diff: https://reviews.apache.org/r/62136/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
