> On Sept. 7, 2017, 2:20 a.m., Vamsee Yarlagadda wrote: > > IMPORTANT: > > http://github.mtv.cloudera.com/CDH/sentry/blob/cdh5-1.5.1/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java#L307-L312 > > We should handle the case when the HDFSSync is also not enabled. Currently > > we only purge when the sync is present but ideally this should be done in > > both the cases.
This gets even more complicated. We should also cleanup CounterWait() otherwise the log is being cluttered as: ```bash 2017-09-06 19:56:21,655 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 821 is smaller then the previous one 9025 2017-09-06 19:56:21,659 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 822 is smaller then the previous one 9025 2017-09-06 19:56:21,677 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 823 is smaller then the previous one 9025 2017-09-06 19:56:21,693 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 824 is smaller then the previous one 9025 2017-09-06 19:56:22,116 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 824 is smaller then the previous one 9025 2017-09-06 19:56:22,144 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 824 is smaller then the previous one 9025 2017-09-06 19:56:22,160 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 825 is smaller then the previous one 9025 2017-09-06 19:56:22,177 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 826 is smaller then the previous one 9025 2017-09-06 19:56:22,617 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 826 is smaller then the previous one 9025 2017-09-06 19:56:22,646 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 826 is smaller then the previous one 9025 2017-09-06 19:56:23,116 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 826 is smaller then the previous one 9025 2017-09-06 19:56:23,145 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 826 is smaller then the previous one 9025 ``` - Vamsee ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/#review184776 ----------------------------------------------------------- On Sept. 7, 2017, 1:27 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62146/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 1:27 a.m.) > > > Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1929 > https://issues.apache.org/jira/browse/SENTRY-1929 > > > Repository: sentry > > > Description > ------- > > SENTRY-1929 When full HMS snapshot is created all higher notifications should > be purged > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6 > > > Diff: https://reviews.apache.org/r/62146/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
