> On Sept. 7, 2017, 10:43 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java > > Lines 89 (patched) > > <https://reviews.apache.org/r/62177/diff/1/?file=1818135#file1818135line89> > > > > Nit: why do we need to set it if the value is the same? So shouldn't it > > be `<=` ?
Yeah, this condition does not make sense, but I added it just in case the PathsDeltaRetriever is changed in the future. I'm not sure about this condition, though. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62177/#review184902 ----------------------------------------------------------- On Sept. 7, 2017, 10:23 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62177/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 10:23 p.m.) > > > Review request for sentry, Alexander Kolbasov and Vamsee Yarlagadda. > > > Bugs: sentry-1931 > https://issues.apache.org/jira/browse/sentry-1931 > > > Repository: sentry > > > Description > ------- > > The patch sets the image ID to the PathsUpdate object so the HDFS can get the > updated information. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/DeltaRetriever.java > 450395079970904398517a9e318d54848e06003b > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java > ccc10ef77635aa951569ac921409f9ded44d8cba > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PermissionsUpdate.java > 7aa60a318b1138000ac17d0d40ca99b1cb859559 > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/Updateable.java > 795aac7b3919b4ea1a7bcc1d385128639c91217d > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java > 819b6b2932bcad3e4e52e282766ad16bb5408d03 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 5d744214e14d6c48194b3a0bf84d6e10070b020a > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java > fda7455d284002ced547c9e4b695fc8efb4ed207 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermDeltaRetriever.java > df6a0b0afd1e0d1e99c4ce3d7b40e34a2117ad41 > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > 8fbc10048003ab4b8a38676e241ae0fd27d2392c > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDeltaRetriever.java > 63b8caf2faa95bdf0b63affbcac96653765af2ea > > > Diff: https://reviews.apache.org/r/62177/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
