----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62192/#review185015 -----------------------------------------------------------
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 705 (original), 705 (patched) <https://reviews.apache.org/r/62192/#comment261248> You can use LOG.debug("Cannot create authz obj path for {} because it is outside of prefix", authzObj); It has better performance. - Na Li On Sept. 8, 2017, 7:23 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62192/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2017, 7:23 p.m.) > > > Review request for sentry, Alexander Kolbasov, Na Li, and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Currently HMSPath logs too much information when it skips paths which are > outside the prefix: > > //Begin of log snippet > 2017-09-07 15:29:39,041 INFO org.apache.sentry.hdfs.HMSPaths: Path outside > prefix > 2017-09-07 15:29:39,040 INFO org.apache.sentry.hdfs.HMSPaths: Skipping to > create authzObjPath as it is outside of prefix. authObj = l5_foo.customer_v1 > pathElements=[data, blah, l5_blah_blah, CUSTOMER_V1, eap_part_no=12345] > //End of log snippet > > This happens when Sentry sends a full snapshot and when NameNode receives > delta snapshots. > Probably we should log information more clearly and log at DEBUG level. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > 5a982637d > > > Diff: https://reviews.apache.org/r/62192/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
