> On Sept. 13, 2017, 12:39 a.m., Misha Dmitriev wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
> > Lines 1774 (patched)
> > <https://reviews.apache.org/r/62261/diff/1/?file=1820339#file1820339line1800>
> >
> >     Looks like in the old code, 'groupName == null' was supported, and 
> > getAllRoles(pm) was returned in that case. I don't think it happening here 
> > anymore?
> 
> Alexander Kolbasov wrote:
>     We never call it with groupName == null

Actually tests do, so dealing with this case as well.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62261/#review185252
-----------------------------------------------------------


On Sept. 12, 2017, 11:26 p.m., Alexander Kolbasov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62261/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2017, 11:26 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Brian Towles, Misha Dmitriev, Na Li, 
> Sergio Pena, and Vamsee Yarlagadda.
> 
> 
> Bugs: SENTRY-1937
>     https://issues.apache.org/jira/browse/SENTRY-1937
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1937 Optimize performance for listing sentry roles by group name
> 
> 
> Diffs
> -----
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  01a7c830f548d41062fb3bbd0a81f71514585aa5 
> 
> 
> Diff: https://reviews.apache.org/r/62261/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Reply via email to