> On Sept. 13, 2017, 5:27 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 201 (original), 203 (patched) > > <https://reviews.apache.org/r/62221/diff/5/?file=1820822#file1820822line203> > > > > We go to so much trouble to print this message and I don't see why it > > is useful. The important part is the advance of notification IDs that can > > be tracked through metrics. What if it successfully processed one message > > but not the rest? How would this message help someone? > > Arjun Mishra wrote: > For supportability purposes. What we want is to print that HMSFollower to > HMS connection is good only when service is started or as soon as specific > HMSFollower instance becomes the leader
That is a fair point. This is addressing other scenario of knowing if HMSFollower to HMS connection is good without having to log it every 0.5 sec - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62221/#review185309 ----------------------------------------------------------- On Sept. 13, 2017, 2:26 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62221/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2017, 2:26 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Na Li, Sergio > Pena, and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Sentry Supportability improvement. > > 1. HMSFollower > * Print confirmation message (at INFO level) once full snapshot is persisted > in the DB. > * Print the message that HMSFollower is completely ready (after the initial > pass of HMSFollower is done) > > 2. DBUpdateForwarder > * Every log message should explicitly mention which type of events is it > referring to (PERM or PATH) otherwise there is no way for us to differentiate > between calls. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 8a34d5623 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java > 1318082d3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 31fd4597d > > > Diff: https://reviews.apache.org/r/62221/diff/5/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
