----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62409/#review185721 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 2844 (patched) <https://reviews.apache.org/r/62409/#comment262034> The comment (and the name) are a bit confusing. I would think that we are deleting all snapshot starting from the one provided and going forward, but you are deleting them going backwards. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 2867 (patched) <https://reviews.apache.org/r/62409/#comment262035> Hmm, this comment is very criptic. What are you trying to say? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Lines 335 (patched) <https://reviews.apache.org/r/62409/#comment262050> I think it makes sense to ignore exception during cleanup. - Alexander Kolbasov On Sept. 19, 2017, 2:51 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62409/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2017, 2:51 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Na Li. > > > Bugs: sentry-1949 > https://issues.apache.org/jira/browse/sentry-1949 > > > Repository: sentry > > > Description > ------- > > Added a new method on SentryStore to delete HMS snapshots since a specific > ID. This new method is called by the HMSFollower when a new snapshot is > created. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 9a37ac8fe572a98b3fb4cba127bcb1716bd8f017 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 31fd4597dad6b02bb5d8b9f944a488f6f78d7d79 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > cf83e7796fd5bc22c76cba6096b0a821e82b87a7 > > > Diff: https://reviews.apache.org/r/62409/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
