----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62654/#review186843 -----------------------------------------------------------
I need to have closer look at your code. I found it in my first pass. sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java Line 243 (original), 255-336 (patched) <https://reviews.apache.org/r/62654/#comment263677> All these three methods have duplicate functionality. Only varient is, AuthorizableType. You can move this iteratinv logic to a utility method and re-use it. I need to have closer look at your code. I found it in my first pass. - kalyan kumar kalvagadda On Sept. 28, 2017, 4:59 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62654/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2017, 4:59 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > Sentry extracts info for authorization based on input from hive instead of > parsing the sql command again > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/SentryAuthorizerFactory.java > 8b56c49 > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java > 6c2410b > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/SentryHiveAuthorizationValidator.java > 7bf7b87 > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/util/SentryAuthorizerUtil.java > 35bd68c > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/util/SimpleSemanticAnalyzer.java > 85afe52 > > sentry-binding/sentry-binding-hive-v2/src/test/java/org/apache/sentry/binding/hive/util/TestSentryAuthorizerUtil.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62654/diff/2/ > > > Testing > ------- > > e2e tests and system test > > > Thanks, > > Na Li > >
