----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62496/#review187001 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java Lines 400 (patched) <https://reviews.apache.org/r/62496/#comment263952> Is it the right format? Per javadoc, it would matche this signature: "error(String format, Object arg1, Object arg2)", where exception e is just another object, so there should be a placeholder for it in a format string. The signature for Throwable is "error(String msg, Throwable t)", which would require "LOGGER.error("Unable to delete " + path, e);" - Vadim Spector On Sept. 22, 2017, 6:28 p.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62496/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2017, 6:28 p.m.) > > > Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar > kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1963 > https://issues.apache.org/jira/browse/SENTRY-1963 > > > Repository: sentry > > > Description > ------- > > SENTRY-1963: Sentry JSON reporter should use regular implementation for local > file system > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java > 4063a663c86ea5ed88c40013d5b3550ac0a6272f > > > Diff: https://reviews.apache.org/r/62496/diff/3/ > > > Testing > ------- > > New unit test written > > > Thanks, > > Alexander Kolbasov > >
