----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62791/ -----------------------------------------------------------
Review request for sentry. Bugs: SENTRY-1974 https://issues.apache.org/jira/browse/SENTRY-1974 Repository: sentry Description ------- The Solr + Kafka PrivilegeValidators, as used by the Sentry Generic Shell, share a lot of duplicate code. Instead we should just have a single GenericPrivilegeValidator. Diffs ----- sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java d9dcbb7e sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 37adb560 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConverter.java c1aac6a5 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryConfigToolSolr.java b958b09d sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellGeneric.java 49523a4b sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConverter.java f24ebed0 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryConfigToolSolr.java d199d20e Diff: https://reviews.apache.org/r/62791/diff/1/ Testing ------- Tested Solr + Kafka privileges in the Shell. Thanks, Colm O hEigeartaigh