----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62812/#review187851 -----------------------------------------------------------
Ship it! The patchs looks good. +1 - Sergio Pena On Oct. 6, 2017, 5:01 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62812/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2017, 5:01 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1975 > https://issues.apache.org/jira/browse/SENTRY-1975 > > > Repository: sentry > > > Description > ------- > > This task is to add sqoop support to SentryShellGeneric. Currently it only > works with Kafka and Solr. > > > Diffs > ----- > > bin/sentryShell 6fd28485 > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java > 5d0831ee > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java > ea8cf079 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellGeneric.java > e3edc296 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryShellCommon.java > b2b6f4fc > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSqoop.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62812/diff/1/ > > > Testing > ------- > > Tested sentryShell with sqoop privileges. > > > Thanks, > > Colm O hEigeartaigh > >
