----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63026/#review188184 -----------------------------------------------------------
Ship it! Patch looks good. - Sergio Pena On Oct. 16, 2017, 11:33 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63026/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 11:33 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1979 > https://issues.apache.org/jira/browse/SENTRY-1979 > > > Repository: sentry > > > Description > ------- > > This task is to consolidate the code for converting Hive privileges objects > to Strings. We have some duplicate code that is used by the shell that could > be removed. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/CommandUtil.java > 51ee9efc > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/GrantPrivilegeToRoleCmd.java > e3d06a97 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/ListPrivilegesCmd.java > 5f3e9fbc > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/RevokePrivilegeFromRoleCmd.java > fe6aca5d > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentryShellHive.java > 81059c5f > > > Diff: https://reviews.apache.org/r/63026/diff/1/ > > > Testing > ------- > > Tested the Hive Shell. > > > Thanks, > > Colm O hEigeartaigh > >
