----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51445/#review188587 -----------------------------------------------------------
Ship it! Ship It! - kalyan kumar kalvagadda On Aug. 30, 2016, 6:38 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51445/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 6:38 p.m.) > > > Review request for sentry, Dapeng Sun, Hao Hao, and Sravya Tirukkovalur. > > > Bugs: SENTRY-1453 > https://issues.apache.org/jira/browse/SENTRY-1453 > > > Repository: sentry > > > Description > ------- > > As it currently stands user will have to set some sentry related configs in > Kafka's config and some in Sentry's configs. Configuration can be eased by > allowing users to pass all related configs in one place. One way is to enable > passing sentry client cache configs from Kafka conf. > > > Diffs > ----- > > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java > 5fc4a5cc4b737858470812488d43ca7a73c36ab2 > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java > 3b1cb9cca017da62578cafef2ce273703482ffdd > > sentry-tests/sentry-tests-kafka/src/main/java/org/apache/sentry/tests/e2e/kafka/KafkaTestServer.java > b82c0281db431067eb827ba559e6a231e255d780 > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java > 02d51c0a68e8b4bacb8ad66e1850f96c09a6eaf2 > > > Diff: https://reviews.apache.org/r/51445/diff/3/ > > > Testing > ------- > > Tested with e2e kafka tests. > > > Thanks, > > Ashish Singh > >
