----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63046/#review188781 -----------------------------------------------------------
Ship it! Looks good to me. You brought the classes from the HiveV2 binding, right. - kalyan kumar kalvagadda On Oct. 17, 2017, 7:11 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63046/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 7:11 p.m.) > > > Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and > kalyan kumar kalvagadda. > > > Bugs: sentry-1980 > https://issues.apache.org/jira/browse/sentry-1980 > > > Repository: sentry > > > Description > ------- > > This is the 2nd part of moving the authz2 HMS client filter classes to the > sentry-binding-hive module. > Most of it is only refactoring (copied classes from hive-authz2). > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizationValidator.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerFactory.java > 76a757ae34699d4f4d3b0a6c370291c135f05d8c > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java > 4aff76f5b2ec0abf40df3e3de99f045482fc17ee > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/util/SimpleSemanticAnalyzer.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63046/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >