----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/#review188866 -----------------------------------------------------------
Ship it! New patch added call to hmsPaths.addPathsToAuthzObject(), which allows passing paths with empty elements. This is a public API, so it should be used for other tests too, but this will be addressed by another JIRA. For the scope of this JIRA, it would cause StringIndexOutOfBoundsException without Misha's fix, so now we directly test the fix. - Vadim Spector On Oct. 20, 2017, 7:14 p.m., Misha Dmitriev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63086/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2017, 7:14 p.m.) > > > Review request for sentry, Alexander Kolbasov and Vadim Spector. > > > Bugs: SENTRY-1993 > https://issues.apache.org/jira/browse/SENTRY-1993 > > > Repository: sentry > > > Description > ------- > > SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPathsDumper.java > 1267093dbbdeb291ec01ecdc87253a90e8ab98ac > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPathsFullDump.java > 6a4e32f6ad180bc1c2ecb6d0be7cdae6c586505d > > > Diff: https://reviews.apache.org/r/63086/diff/2/ > > > Testing > ------- > > > Thanks, > > Misha Dmitriev > >
